Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profile flag documentation indentation #4645

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Fix profile flag documentation indentation #4645

merged 2 commits into from
Jul 3, 2019

Conversation

josedonizetti
Copy link
Member

The --profile documentation display is currently broken:

 -p, --profile string                   The name of the minikube VM being used.  
                                         	This can be modified to allow for multiple minikube instances to be run independently (default "minikube")

vs

-p, --profile string                   The name of the minikube VM being used. This can be modified to allow for multiple minikube instances to be run independently (default "minikube")

wdyt?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @josedonizetti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josedonizetti
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

medyagh
medyagh reviewed Jun 30, 2019
View reviewed changes
cmd/minikube/cmd/root.go Outdated Show resolved Hide resolved
@RA489
Copy link

RA489 commented Jul 1, 2019

@minikube-bot Ok-to-test

medyagh
medyagh reviewed Jul 1, 2019
View reviewed changes
cmd/minikube/cmd/root.go Outdated Show resolved Hide resolved
@josedonizetti josedonizetti mentioned this pull request Jul 2, 2019
Closed
6 tasks
@RA489
Copy link

RA489 commented Jul 3, 2019

@minikube-bot OK to test

@medyagh medyagh merged commit 68c546f into kubernetes:master Jul 3, 2019
@josedonizetti josedonizetti deleted the fix-profile-flag-indentation branch July 3, 2019 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josedonizetti @k8s-ci-robot @minikube-bot @RA489 @medyagh